fix: fixed incorrect and broken translations by maxprilutskiy · Pull Request #638 · Mail-0/Zero

maxprilutskiy · 2025-04-10T22:14:50Z

Description

Hi @nizzyabi @MrgSub @ahmetskilinc! I've just found out hundreds of incorrect + missing translations in Zero, particularly in Arabic and Hindi where files were basically a mix of English and the target language, while Polish was missing entirely. This PR fixes these issues using @lingodotdev open source CLI to provide accurate translations across all affected language files.

This PR addresses translation issues in multiple languages with the following counts of fixes:

Bonus:

Added Hungarian language (Request for Hungarian translation option. #626)
Added @lingodotdev open-source CLI to GitHub CI, to check for missing translations in real-time, so the UX is great ✨

Type of Change

Please delete options that are not relevant.

🐛 Bug fix (non-breaking change which fixes an issue)
🎨 UI/UX improvement

Areas Affected

Please check all that apply:

User Interface/Experience

Security Considerations

No sensitive data is exposed

Checklist

I have read the CONTRIBUTING document
My code follows the project's style guidelines
I have performed a self-review of my code
I have commented my code, particularly in complex areas
I have updated the documentation
My changes generate no new warnings
I have added tests that prove my fix/feature works
All tests pass locally
Any dependent changes are merged and published

Replaces #635

By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.

…anish, French, Hindi, Japanese, Korean, Latvian, Polish, Portuguese, Turkish

vercel · 2025-04-10T22:14:54Z

@maxprilutskiy is attempting to deploy a commit to the Zero Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai · 2025-04-10T22:14:59Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

maxprilutskiy · 2025-04-10T22:15:26Z

.github/workflows/ci.yml

+        with:
+          node-version: latest
+
+      - name: Install dependencies 📦


cleanup, added name to the step :)

maxprilutskiy · 2025-04-10T22:16:01Z

.github/workflows/main.yml

+        if: ${{ !inputs.skip_localization }}
+        uses: lingodotdev/lingo.dev@main
+        with:
+          api-key: ${{ secrets.LINGODOTDEV_API_KEY }}


will check for missing translations using @lingodotdev open source tooling

maxprilutskiy · 2025-04-10T22:16:21Z

apps/mail/i18n/config.ts

  tr: "Turkish",
-  lv: "Latvian"
+  lv: "Latvian",
+  hu: "Hungarian",


added support for Hungarian, as requested in #626

vercel · 2025-04-10T22:59:28Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
0	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 10, 2025 11:02pm

nizzyabi · 2025-04-11T00:46:41Z

great

…

On Thu, Apr 10, 2025 at 4:11 PM Adam ***@***.***> wrote: Merged #638 <#638> into staging. — Reply to this email directly, view it on GitHub <#638 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BBP7RAFB53OPQ4BAFH6O6LD2Y33BPAVCNFSM6AAAAAB24YMVO2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJXGIYTKMJQHE4DCMQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

nizzyabi · 2025-04-11T00:48:11Z

amazibg

…

On Thu, Apr 10, 2025 at 5:46 PM Nizar ***@***.***> wrote: great On Thu, Apr 10, 2025 at 4:11 PM Adam ***@***.***> wrote: > Merged #638 <#638> into staging. > > — > Reply to this email directly, view it on GitHub > <#638 (comment)>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/BBP7RAFB53OPQ4BAFH6O6LD2Y33BPAVCNFSM6AAAAAB24YMVO2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJXGIYTKMJQHE4DCMQ> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> >

maxprilutskiy added 3 commits April 10, 2025 15:11

fix: fix incorrect translations in Arabic, Catalan, Czech, German, Sp…

f5a7812

…anish, French, Hindi, Japanese, Korean, Latvian, Polish, Portuguese, Turkish

feat: install @lingodotdev

04a5f6f

feat: add Hungarian

7febfef

maxprilutskiy commented Apr 10, 2025

View reviewed changes

Merge branch 'staging' into staging

b127a95

vercel bot temporarily deployed to Preview April 10, 2025 23:02 Inactive

MrgSub approved these changes Apr 10, 2025

View reviewed changes

MrgSub merged commit 8bfc285 into Mail-0:staging Apr 10, 2025
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: fixed incorrect and broken translations#638

fix: fixed incorrect and broken translations#638
MrgSub merged 4 commits intoMail-0:stagingfrom
maxprilutskiy:staging

maxprilutskiy commented Apr 10, 2025 •

edited

Loading

Uh oh!

vercel bot commented Apr 10, 2025

Uh oh!

coderabbitai bot commented Apr 10, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

maxprilutskiy Apr 10, 2025

Uh oh!

maxprilutskiy Apr 10, 2025

Uh oh!

maxprilutskiy Apr 10, 2025

Uh oh!

vercel bot commented Apr 10, 2025 •

edited

Loading

Uh oh!

Uh oh!

nizzyabi commented Apr 11, 2025 via email

Uh oh!

nizzyabi commented Apr 11, 2025 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

maxprilutskiy commented Apr 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of Change

Areas Affected

Security Considerations

Checklist

Uh oh!

vercel bot commented Apr 10, 2025

Uh oh!

coderabbitai bot commented Apr 10, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

maxprilutskiy Apr 10, 2025

Choose a reason for hiding this comment

Uh oh!

maxprilutskiy Apr 10, 2025

Choose a reason for hiding this comment

Uh oh!

maxprilutskiy Apr 10, 2025

Choose a reason for hiding this comment

Uh oh!

vercel bot commented Apr 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

nizzyabi commented Apr 11, 2025 via email

Uh oh!

nizzyabi commented Apr 11, 2025 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

maxprilutskiy commented Apr 10, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

vercel bot commented Apr 10, 2025 •

edited

Loading